Skip to content

Remove PROJECT_OPEN_NEW_PERSPECTIVE Constant #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Remove PROJECT_OPEN_NEW_PERSPECTIVE Constant #2971

merged 1 commit into from
Jul 22, 2025

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented May 12, 2025 •
edited
Loading

The effective preference used by Eclipse is now under org.eclipse.ui.ide.
The deprecated constant (IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE)
from org.eclipse.ui no longer affects the current project-opening behavior.

iloveeclipse
iloveeclipse requested changes May 12, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 44m 56s ⏱️ + 7m 7s
 7 932 tests ±0   7 703 ✅ ±0  228 💤 ±0  1 ❌ ±0 
23 351 runs  ±0  22 604 ✅ ±0  746 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6f24168. ± Comparison against base commit bd09a12.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented May 12, 2025 •
edited
Loading

Maybe the deprecated addition (from 2004) should finally be removed from the preferences initializer?

image

@elsazac
Copy link
Member Author

elsazac commented Jun 19, 2025

Maybe the deprecated addition (from 2004) should finally be removed from the preferences initializer?

Can this be removed now? , as the effective preference used by the Eclipse IDE is the one under org.eclipse.ui.ide, not the one in org.eclipse.ui? I don’t think the deprecated one (IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE) no longer influences current project-opening behaviour.

@merks
Copy link
Contributor

merks commented Jun 19, 2025

Yes I doubt it’s relevant

@elsazac elsazac force-pushed the UseIDEPref branch 2 times, most recently from ba478d0 to 06018c8 Compare June 20, 2025 12:11
@elsazac elsazac requested a review from iloveeclipse June 23, 2025 05:40
@elsazac
Copy link
Member Author

elsazac commented Jun 24, 2025

Yes I doubt it’s relevant

I’ve pushed the changes again — is this good to go now?

@elsazac elsazac force-pushed the UseIDEPref branch 3 times, most recently from e0fa32b to 1a59188 Compare June 26, 2025 13:21
@elsazac
Copy link
Member Author

elsazac commented Jul 18, 2025

I’ve pushed the changes again — is this good to go now?

@merks Is this good to go? or do you have any suggestions?

merks
merks approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s fine.

@elsazac
Copy link
Member Author

elsazac commented Jul 22, 2025

tests looks good now;

@elsazac
Copy link
Member Author

elsazac commented Jul 22, 2025

@iloveeclipse Could you approve this?

iloveeclipse
iloveeclipse requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase that on master, squash all commits to one, and give an appropriate commit message.

See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

bundles/org.eclipse.ui/src/org/eclipse/ui/internal/UIPreferenceInitializer.java Outdated
// Deprecated but kept for backwards compatibility
node.put(IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE,
IWorkbenchPreferenceConstants.OPEN_PERSPECTIVE_REPLACE);
// testing and Fixing CI errors -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@elsazac elsazac changed the title Replace PROJECT_OPEN_NEW_PERSPECTIVE Constant with IDE.Preferences Equivalent Remove PROJECT_OPEN_NEW_PERSPECTIVE Constant Jul 22, 2025
@elsazac
Copy link
Member Author

elsazac commented Jul 22, 2025

Please rebase that on master, squash all commits to one, and give an appropriate commit message.

See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

I have given a new commit message.

@iloveeclipse
Copy link
Member

This is what contribution guideline says:
image

And this is the commit message:

The effective preference used by the Eclipse IDE is the one under](https://github.com/eclipse-platform/eclipse.platform.ui/pull/2971/commits/7c96f493cc6228997e79d35f4bdf801fa7d428cc)
org.eclipse.ui.ide, not the one in org.eclipse.ui. deprecated
IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE no longer
influences current project-opening behaviour.

Do you see my point?

@elsazac
Remove the deprecated constant PROJECT_OPEN_NEW_PERSPECTIVE
6f24168 
The effective preference used by Eclipse is now under org.eclipse.ui.ide
.The deprecated constant
(IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE)
from org.eclipse.ui no longer affects the current project-opening
behaviour and hence its removed from the codebase.
@elsazac
Copy link
Member Author

elsazac commented Jul 22, 2025

Do you see my point?

Yes, I have made the changes now; Hope that looks okay.

@elsazac
Copy link
Member Author

elsazac commented Jul 22, 2025

Do you see my point?

Yes, I have made the changes now; Hope that looks okay.

@iloveeclipse I have made the changes; could you approve this?

@iloveeclipse iloveeclipse merged commit 477d106 into eclipse-platform:master Jul 22, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merks merks merks approved these changes

@iloveeclipse iloveeclipse iloveeclipse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsazac @merks @iloveeclipse