-
Notifications
You must be signed in to change notification settings - Fork 220
Remove PROJECT_OPEN_NEW_PERSPECTIVE Constant #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 2 778 files ±0 2 778 suites ±0 1h 44m 56s ⏱️ + 7m 7s For more details on these failures, see this check. Results for commit 6f24168. ± Comparison against base commit bd09a12. ♻️ This comment has been updated with latest results. |
Can this be removed now? , as the effective preference used by the Eclipse IDE is the one under org.eclipse.ui.ide, not the one in org.eclipse.ui? I don’t think the deprecated one (IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE) no longer influences current project-opening behaviour. |
Yes I doubt it’s relevant |
ba478d0
to
06018c8
Compare
I’ve pushed the changes again — is this good to go now? |
e0fa32b
to
1a59188
Compare
@merks Is this good to go? or do you have any suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s fine.
tests looks good now; |
@iloveeclipse Could you approve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase that on master, squash all commits to one, and give an appropriate commit message.
See https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations
// Deprecated but kept for backwards compatibility | ||
node.put(IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE, | ||
IWorkbenchPreferenceConstants.OPEN_PERSPECTIVE_REPLACE); | ||
// testing and Fixing CI errors - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I have given a new commit message. |
The effective preference used by Eclipse is now under org.eclipse.ui.ide .The deprecated constant (IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE) from org.eclipse.ui no longer affects the current project-opening behaviour and hence its removed from the codebase.
Yes, I have made the changes now; Hope that looks okay. |
@iloveeclipse I have made the changes; could you approve this? |
The effective preference used by Eclipse is now under
org.eclipse.ui.ide.
The deprecated constant (
IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE
)from
org.eclipse.ui
no longer affects the current project-opening behavior.